DELTA 237 0 964
SVN  Š›'’ ƒf  „Zƒb€’ P‰E
 Specificationin threadHTML: Storing the HTML in a python string as it is
   generated seems like an inefficient method of HTML generation.

 Routines:
 - getPageHTML: This function seems to be redundant, doing the work of
   getThreadHTML.  Both functions claim to return the complete, ready
   to display HTML code.

Questions:

 - The method a keeping track of a user's skin seems odd.  What is the
   reason for storing this in a string?

 - in threadHTML: "Thus the algorithm would consist of:" ends without
   an algorithm, in my reading of this review.  Is there an algorithm
   explained in routines.txt?

Issues to Explore:

 - Should a more complete preferences system exist to combine ugly
   constructs such as CSS_LOC and a string storing the user's skin?
   Is this beyond the scope of the project, or would it allow further
   expansion of the capabilities?

Advice:

 - Consider developing a more structured preferences system for each
   user.

 - Consider reworking the architecture to allow the HTML to be
   displayed as it is being generated, not storing it as a string
   until the end.  This method seems to be inefficient, and since we
   are generating code that can be directly outputted, there is a more
   efficient method.


Test Plan Review
--------------------------------
Problems:

 Overall
 - Requiring the database to exist in the background to serve the
   posts does not allow concurrent testing.

 Acceptance Testing
 - The conditions of the database should be specified in the
   acceptance tests.

 - each acceptance test is testing many different requirements.

 Functional Testing

 - SpGetHTMLOut: The definition of what is valid HTML is presented
   here, but is limiting.

 - 

 Whitebox Testing

 - 

Questions:

 - How is HTML compliance tested for?  Are IE6/7 standards used?  Is
   it w3c compliant?  Can any of these standards guarantee operability
   in IE6/7, Gecko, KHTML, Opera?  Are there accessibility
   requirements for easy reading of the webpage for the visually
   impared?

 - How are acceptance tests passed?  The definition of "correctly
   displayed" is weak.

 - What is a "Major bug" in HTML?  How does this get tested for?

Issues to Explore:

 - Can the acceptance tests be broken into components that only test
   one aspect of the requirements at a time?ENDREP
id: dl.0.r247/2379
type: file
pred: dl.0.r240/1305
count: 2
text: 247 0 2356 3495 023bcec29730bb07e3e97b1710d8de02
props: 237 977 51 0 b29e6c0f9ffda24088f6b1b3e2b62c8d
cpath: /project5/CommentsOnPackage/Morgan/comments.txt
copyroot: 0 /

PLAIN
K 12
comments.txt
V 19
file dl.0.r247/2379
END
ENDREP
id: dk.0.r247/2677
type: dir
pred: dk.0.r240/1603
count: 2
text: 247 2617 47 47 085b4a46d58c3e27b33c84b4a88a4951
cpath: /project5/CommentsOnPackage/Morgan
copyroot: 0 /

PLAIN
K 5
Chris
V 18
dir dm.0.r245/1263
K 5
Jason
V 18
dir dg.0.r235/6591
K 3
Jay
V 18
dir cu.0.r246/3693
K 3
Joe
V 18
dir di.0.r243/5019
K 6
Morgan
V 18
dir dk.0.r247/2677
END
ENDREP
id: ct.0.r247/3031
type: dir
pred: ct.0.r246/4046
count: 24
text: 247 2847 171 171 7c3e51fc76716bcfeaa797ce84a753cb
cpath: /project5/CommentsOnPackage
copyroot: 0 /

PLAIN
K 17
CommentsOnPackage
V 18
dir ct.0.r247/3031
K 5
Jason
V 18
dir c4.0.r198/1191
K 3
Jay
V 17
dir cs.0.r223/824
K 6
Morgan
V 18
dir db.0.r219/1192
K 17
Project5-Plan.pdf
V 20
file c3.0.r193/21228
K 13
ReviewPackage
V 18
dir ch.0.r200/3700
END
ENDREP
id: c2.0.r247/3453
type: dir
pred: c2.0.r246/4468
count: 54
text: 247 3197 243 243 e35d1b83a129872ce02ee6cf65070bd9
cpath: /project5
copyroot: 0 /

PLAIN
K 8
project2
V 17
dir 1.0.r30/25403
K 8
project3
V 17
dir 22.0.r98/1882
K 8
project4
V 18
dir ap.0.r205/1464
K 8
project5
V 18
dir c2.0.r247/3453
END
ENDREP
id: 0.0.r247/3764
type: dir
pred: 0.0.r246/4779
count: 247
text: 247 3601 150 150 41bf81999795ab97486d95b001c60c25
cpath: /
copyroot: 0 /

dl.0.t246-1 modify true false /project5/CommentsOnPackage/Morgan/comments.txt


3764 3903