Changes between Version 12 and Version 13 of CodeReview


Ignore:
Timestamp:
12/06/2011 10:40:22 AM (4 years ago)
Author:
hwu
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • CodeReview

    v12 v13  
    3939
    4040See: http://www.python.org/dev/peps/pep-0008/
     41
     42= Code Review =
     43
     44c. print statements that are commented out. Better to put it into an output log to make it go into
     45
     46Some parts are too obvious on comments and some parts require some more comments
     47
     48Hard coding stuff for initializing.
     49
     50
     51b. array of country ids instead of the country names?
     52lots of constants and not sure what they do, comment that says what are the reasonable ranges for each variable
     53
     54defined position in button, not window
     55
     56d. popup.py
     57comments that are obvious
     58hardcode window size and positions, defining relative positions instead of hardcode
     59
     60comments that say what the magic numbers in code are even though its based on other code
     61
     62a. commented out code that needs to be removed
     63   backslashes not consistent
     64   supply curve could use more comments for the numbers
     65
     66Rubric
     67
     68biggest issue for extensibility is the hard coding of the constants
     69
     70policy guidelines don't necessarily make the code easy to understand
     71private variables should have been notated separately
     72
     73code is not sufficiently commented
     74
     75style: backslashes
     76
     77extensibility: hard coding, design is not so extensible
     78
     79debugging: redirect print statements to output file (if debug etc) so that it facilitates debugging
     80
     81