Opened 3 years ago

Closed 3 years ago

#61 closed defect (fixed)

prototype: State refactoring

Reported by: jelinson Owned by: rthomas
Priority: minor Milestone: milestone3
Component: component1 Version:
Keywords: Cc:
Blocked By: Blocking:


returnUpdateStats is confusing. It should haven't return in its name. Either return the spec as is or define a getter method. Second, is the negative 50 the dollar amount you get each turn? If so, that should be a constant. Lastly, why does it make a new spec instead of using its own?

Change History (4)

comment:1 Changed 3 years ago by ecoughlan

  • Priority changed from major to minor

comment:2 Changed 3 years ago by rthomas

  • Milestone changed from milestone2 to milestone3

comment:3 Changed 3 years ago by jelinson

  • Owner changed from somebody to rthomas
  • Status changed from new to assigned

comment:4 Changed 3 years ago by rthomas

  • Resolution set to fixed
  • Status changed from assigned to closed

The reason it doesn't use its own spec is because the game state does the calculating and it doesn't have the changes from during the turn. So it creates a change spec for the turn state to use.

Note: See TracTickets for help on using tickets.